Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds comprehensive database tests for validator management and checkpoints, while also refactoring database query parameter passing to use dictionary-based named parameters instead of tuples.
Changes:
- Added complete test coverage for
NetworkValidatorCrud,CheckpointCrud, andVaultValidatorCrudclasses - Refactored SQL query parameter passing from tuple-based to dictionary-based named parameters for improved clarity
- Added a UNIQUE constraint to the checkpoints table to prevent duplicate entries
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/validators/tests/test_database.py | New test file with comprehensive test coverage for all three CRUD classes including edge cases and validation |
| src/validators/database.py | Refactored parameter passing to use dictionaries and added UNIQUE constraint to checkpoints table |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…tion" This reverts commit 0e5a813.
Signed-off-by: cyc60 <avsysoev60@gmail.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: cyc60 <avsysoev60@gmail.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: cyc60 <avsysoev60@gmail.com>
No description provided.