Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR replaces the custom chunkify utility function from sw_utils with Python's built-in itertools.batched function. The change modernizes the codebase by utilizing a standard library function that provides the same batching functionality.
Changes:
- Replaced all
chunkifyimports withitertools.batchedimports - Updated function signatures to use
Sequenceinstead oflistfor better type flexibility - Removed unnecessary type ignore comment
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/validators/tasks.py | Replaced chunkify with batched for validator funding batches and updated type hint to Sequence |
| src/validators/relayer.py | Updated type hint from list to Sequence for validator fundings parameter |
| src/validators/keystores/hashi_vault.py | Replaced three instances of chunkify with batched for key loading operations |
| src/validators/consensus.py | Replaced chunkify with batched for validator fetching |
| src/common/credentials.py | Replaced chunkify with batched for credential generation batches |
| src/commands/setup_remote_signer.py | Replaced chunkify with batched and removed type ignore comment |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cyc60
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.