Conversation
Signed-off-by: cyc60 <avsysoev60@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR modifies the client shutdown behavior to make waiting for session closure optional rather than mandatory. The change introduces a parameter to control whether the application waits for web3 evicted sessions to close during shutdown, avoiding unnecessary delays in most cases.
Changes:
- Added optional
wait_sessions_closeparameter toclose_clients()function with a default value ofFalse - Updated the shutdown logic to conditionally wait for sessions based on the parameter
- Explicitly enabled session waiting in the base startup command's cleanup flow
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/common/clients.py | Added wait_sessions_close parameter to make session closure waiting optional during client shutdown |
| src/commands/start/base.py | Enabled session waiting in the base command's cleanup to maintain existing behavior for this specific use case |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
evgeny-stakewise
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.