Conversation
Signed-off-by: cyc60 <avsysoev60@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the loading of validator signing keys from HashiCorp Vault by adding logic to skip empty secret keys and making the vault key path parameter optional.
Changes:
- Added empty string check to skip keys with empty values when loading from Vault
- Made the
--hashi-vault-key-pathparameter optional instead of required - Updated version from v4.1.4 to v4.1.5 across multiple files
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/validators/keystores/hashi_vault.py | Added check to skip empty secret keys during key loading |
| src/commands/start/hashi_vault.py | Removed required flag from --hashi-vault-key-path parameter |
| scripts/install.sh | Updated default version from v4.1.4 to v4.1.5 |
| pyproject.toml | Bumped package version to v4.1.5 |
| README.md | Updated Docker image references to v4.1.5 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: cyc60 <avsysoev60@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
evgeny-stakewise
approved these changes
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.