Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors common/execution.py by extracting withdrawal-related and consolidation-related functionality into separate, domain-specific modules (common/withdrawals.py and common/consolidations.py). This improves code organization and maintainability by grouping related functions together.
Changes:
- Extracted withdrawal functions from
execution.pyinto a newwithdrawals.pymodule - Extracted consolidation functions from
execution.pyinto a newconsolidations.pymodule - Made the
fake_exponentialhelper function public and kept it inexecution.pyfor shared use - Updated imports across affected files to reference the new module locations
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/common/withdrawals.py | New module containing withdrawal-related functions moved from execution.py |
| src/common/consolidations.py | New module containing consolidation-related functions moved from execution.py |
| src/common/execution.py | Removed withdrawal and consolidation functions; exposed fake_exponential as public function |
| src/withdrawals/tasks.py | Updated imports to reference new modules |
| src/commands/exit_validators.py | Updated imports to reference new withdrawals module |
| src/commands/consolidate.py | Updated imports to reference new consolidations and withdrawals modules |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cyc60
approved these changes
Jan 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.