Fix stale validators manager signature#631
Merged
evgeny-stakewise merged 3 commits intomasterfrom Jan 13, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the validator registration flow to handle validators manager signature generation more efficiently. The key improvement is computing the validators registry root once at the beginning and detecting when it changes during the approval polling loop.
Changes:
- Centralized validators manager signature generation logic to avoid duplication between AUTO and relayer modes
- Added registry root change detection in the approval polling loop with a new exception type
- Removed unused exception class and dependency
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/validators/tasks.py | Moved validators registry root fetch and manager signature generation outside mode-specific branches; removed handling of MissingAvailableValidatorsException |
| src/validators/oracles.py | Added registry root change detection; simplified approval request recreation logic by removing redundant registry root comparison |
| src/validators/exceptions.py | Added RegistryRootChangedError exception; removed unused MissingAvailableValidatorsException |
| pyproject.toml | Removed unused aiohttp dependency |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cyc60
approved these changes
Jan 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.