Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the user experience for network parameter handling across multiple commands by removing the default network value and adding clearer error messages. The changes ensure users either specify a network explicitly or run the "init" command first.
Key Changes:
- Removed
DEFAULT_NETWORKimport and default value fromsubmit_rated_networkcommand - Added validation to check for missing network parameter before attempting to use it
- Applied consistent error handling pattern across
submit_rated_network,exit_validators, andconsolidatecommands
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/commands/submit_rated_network.py | Updated network parameter to be optional, removed default value, added validation with helpful error message, and improved help text |
| src/commands/exit_validators.py | Added validation to ensure network is provided or init command has been run |
| src/commands/consolidate.py | Added validation to ensure network is provided or init command has been run |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
evgeny-stakewise
commented
Jan 5, 2026
cyc60
approved these changes
Jan 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.