V4 by cyc60 · Pull Request #528 · stakewise/v3-operator

cyc60 · 2025-09-05T11:28:21Z

No description provided.

* Allow run with multiple vaults Signed-off-by: cyc60 <avsysoev60@gmail.com> * Allow run with multiple vaults Signed-off-by: cyc60 <avsysoev60@gmail.com> * Update readme Signed-off-by: cyc60 <avsysoev60@gmail.com> * Rename to config dir Signed-off-by: cyc60 <avsysoev60@gmail.com> * Update tests Signed-off-by: cyc60 <avsysoev60@gmail.com> * Update tests 2 Signed-off-by: cyc60 <avsysoev60@gmail.com> * Markdown linter fixes Signed-off-by: cyc60 <avsysoev60@gmail.com> * Text improvements Signed-off-by: cyc60 <avsysoev60@gmail.com> * Deposit data cleanup Signed-off-by: cyc60 <avsysoev60@gmail.com> * Registration fixes Signed-off-by: cyc60 <avsysoev60@gmail.com> * Dappnode support Signed-off-by: cyc60 <avsysoev60@gmail.com> * Add web3signer deposit data Signed-off-by: cyc60 <avsysoev60@gmail.com> * Fix remote signer setup Signed-off-by: cyc60 <avsysoev60@gmail.com> * Review fixes #1 Signed-off-by: cyc60 <avsysoev60@gmail.com> * Review fixes #2 Signed-off-by: cyc60 <avsysoev60@gmail.com> * Linter fixes Signed-off-by: cyc60 <avsysoev60@gmail.com> * Rename validator.txt file Signed-off-by: cyc60 <avsysoev60@gmail.com> * Packages update Signed-off-by: cyc60 <avsysoev60@gmail.com> * Review fixes #3 Signed-off-by: cyc60 <avsysoev60@gmail.com> --------- Signed-off-by: cyc60 <avsysoev60@gmail.com>

* Use separate dir for every network Signed-off-by: cyc60 <avsysoev60@gmail.com> * Review fix Signed-off-by: cyc60 <avsysoev60@gmail.com> --------- Signed-off-by: cyc60 <avsysoev60@gmail.com>

* Multivault migration Signed-off-by: cyc60 <avsysoev60@gmail.com> * Migration refactoring Signed-off-by: cyc60 <avsysoev60@gmail.com> * Review fixes Signed-off-by: cyc60 <avsysoev60@gmail.com> --------- Signed-off-by: cyc60 <avsysoev60@gmail.com>

* Support pectra v2 validators registration Signed-off-by: cyc60 <avsysoev60@gmail.com> * Updates for pectra registration Signed-off-by: cyc60 <avsysoev60@gmail.com> * Updates for pectra registration Signed-off-by: cyc60 <avsysoev60@gmail.com> * Review fixes Signed-off-by: cyc60 <avsysoev60@gmail.com> * Remove validators_manager_signature from contract call Signed-off-by: cyc60 <avsysoev60@gmail.com> * Review fixes Signed-off-by: cyc60 <avsysoev60@gmail.com> * Packages update Signed-off-by: cyc60 <avsysoev60@gmail.com> * Update click Signed-off-by: cyc60 <avsysoev60@gmail.com> --------- Signed-off-by: cyc60 <avsysoev60@gmail.com>

* Fund post-pectra Signed-off-by: cyc60 <avsysoev60@gmail.com> * Review fixes Signed-off-by: cyc60 <avsysoev60@gmail.com> * Register new validators after funding current Signed-off-by: cyc60 <avsysoev60@gmail.com> * Register new validators after funding current Signed-off-by: cyc60 <avsysoev60@gmail.com> * Allow to fund new validators Signed-off-by: cyc60 <avsysoev60@gmail.com> * Review fixes Signed-off-by: cyc60 <avsysoev60@gmail.com> * Small cleanup Signed-off-by: cyc60 <avsysoev60@gmail.com> * Remove empty status check Signed-off-by: cyc60 <avsysoev60@gmail.com> * Review fixes Signed-off-by: cyc60 <avsysoev60@gmail.com> * Fix comment Signed-off-by: cyc60 <avsysoev60@gmail.com> --------- Signed-off-by: cyc60 <avsysoev60@gmail.com>

Signed-off-by: cyc60 <avsysoev60@gmail.com>

* Save vault validators keys to database Signed-off-by: cyc60 <avsysoev60@gmail.com> * Fix non_activated_balances Signed-off-by: cyc60 <avsysoev60@gmail.com> * Review fixes Signed-off-by: cyc60 <avsysoev60@gmail.com> * Update sw-utils Signed-off-by: cyc60 <avsysoev60@gmail.com> --------- Signed-off-by: cyc60 <avsysoev60@gmail.com>

* Add validator consolidation Signed-off-by: cyc60 <avsysoev60@gmail.com> * Add more logs Signed-off-by: cyc60 <avsysoev60@gmail.com> * Consolidation fixes Signed-off-by: cyc60 <avsysoev60@gmail.com> * Move tx func to separate module Signed-off-by: cyc60 <avsysoev60@gmail.com> * Update readme Signed-off-by: cyc60 <avsysoev60@gmail.com> * Refactor consolidation Signed-off-by: cyc60 <avsysoev60@gmail.com> * Small fixes Signed-off-by: cyc60 <avsysoev60@gmail.com> * Fix readme Signed-off-by: cyc60 <avsysoev60@gmail.com> * Review fixes Signed-off-by: cyc60 <avsysoev60@gmail.com> * Review fix Signed-off-by: cyc60 <avsysoev60@gmail.com> * Review fixes Signed-off-by: cyc60 <avsysoev60@gmail.com> * Update readme Signed-off-by: cyc60 <avsysoev60@gmail.com> * Update readme Signed-off-by: cyc60 <avsysoev60@gmail.com> --------- Signed-off-by: cyc60 <avsysoev60@gmail.com>

* Fixes for pectra flow: remove v2 pool contract, fix recover, add gas check Signed-off-by: cyc60 <avsysoev60@gmail.com> * Restore V2PoolContract Signed-off-by: cyc60 <avsysoev60@gmail.com> --------- Signed-off-by: cyc60 <avsysoev60@gmail.com>

Signed-off-by: cyc60 <avsysoev60@gmail.com>

* Split start command Signed-off-by: cyc60 <avsysoev60@gmail.com> * Add public-keys option Signed-off-by: cyc60 <avsysoev60@gmail.com> * Review fixes Signed-off-by: cyc60 <avsysoev60@gmail.com> * Fix typo Signed-off-by: cyc60 <avsysoev60@gmail.com> * Review fixes Signed-off-by: cyc60 <avsysoev60@gmail.com> * Review fixes Signed-off-by: cyc60 <avsysoev60@gmail.com> --------- Signed-off-by: cyc60 <avsysoev60@gmail.com>

* Add reward splitter command Signed-off-by: cyc60 <avsysoev60@gmail.com> * Move split reward to task Signed-off-by: cyc60 <avsysoev60@gmail.com> * Refactor graph client, add startup checks Signed-off-by: cyc60 <avsysoev60@gmail.com> * Small fixes Signed-off-by: cyc60 <avsysoev60@gmail.com> * Naming refactoring Signed-off-by: cyc60 <avsysoev60@gmail.com> * Remove graph harvest params, fix multicall batching Signed-off-by: cyc60 <avsysoev60@gmail.com> * Add reward splitter interval and update readme Signed-off-by: cyc60 <avsysoev60@gmail.com> * Review fixes #1 Signed-off-by: cyc60 <avsysoev60@gmail.com> * Review fixes #2 Signed-off-by: cyc60 <avsysoev60@gmail.com> * Check claimer account Signed-off-by: cyc60 <avsysoev60@gmail.com> * Move reward splitter ABI Signed-off-by: cyc60 <avsysoev60@gmail.com> * Update packages Signed-off-by: cyc60 <avsysoev60@gmail.com> * Review fixes Signed-off-by: cyc60 <avsysoev60@gmail.com> * Remove multicall Signed-off-by: cyc60 <avsysoev60@gmail.com> * Remove multicall in comments Signed-off-by: cyc60 <avsysoev60@gmail.com> * Fix reward splitter query Signed-off-by: cyc60 <avsysoev60@gmail.com> * Review fix Signed-off-by: cyc60 <avsysoev60@gmail.com> --------- Signed-off-by: cyc60 <avsysoev60@gmail.com>

Signed-off-by: cyc60 <avsysoev60@gmail.com>

* Add validators withdrawn Signed-off-by: cyc60 <avsysoev60@gmail.com> * Rework queued assets Signed-off-by: cyc60 <avsysoev60@gmail.com> * Review fixes #1 Signed-off-by: cyc60 <avsysoev60@gmail.com> * Validate last withdrawal via consensus Signed-off-by: cyc60 <avsysoev60@gmail.com> * Add full withdrawals Signed-off-by: cyc60 <avsysoev60@gmail.com> * Add tests, small fixes Signed-off-by: cyc60 <avsysoev60@gmail.com> * Add tests Signed-off-by: cyc60 <avsysoev60@gmail.com> * Typo fixes Signed-off-by: cyc60 <avsysoev60@gmail.com> * Review fixes Signed-off-by: cyc60 <avsysoev60@gmail.com> * Simplify get_withdrawals_data Signed-off-by: cyc60 <avsysoev60@gmail.com> * Review fixes Signed-off-by: cyc60 <avsysoev60@gmail.com> * Check execution layer withdrawals queue Signed-off-by: cyc60 <avsysoev60@gmail.com> * Small fixes Signed-off-by: cyc60 <avsysoev60@gmail.com> * Review fixes Signed-off-by: cyc60 <avsysoev60@gmail.com> * Add validators subtasks Signed-off-by: cyc60 <avsysoev60@gmail.com> * Add partial_capacity to validator Signed-off-by: cyc60 <avsysoev60@gmail.com> * Use consensus block execution_requests to validate withdrawal event Signed-off-by: cyc60 <avsysoev60@gmail.com> --------- Signed-off-by: cyc60 <avsysoev60@gmail.com>

Signed-off-by: cyc60 <avsysoev60@gmail.com>

* Add migration guide Signed-off-by: cyc60 <avsysoev60@gmail.com> * Review fixes Signed-off-by: cyc60 <avsysoev60@gmail.com> * Update startup checks Signed-off-by: cyc60 <avsysoev60@gmail.com> * Review fixes Signed-off-by: cyc60 <avsysoev60@gmail.com> * Review fix Signed-off-by: cyc60 <avsysoev60@gmail.com> * Review fix Signed-off-by: cyc60 <avsysoev60@gmail.com> --------- Signed-off-by: cyc60 <avsysoev60@gmail.com> Co-authored-by: Dmitri Tsumak <tsumak.dmitri@gmail.com>

Signed-off-by: cyc60 <avsysoev60@gmail.com>

* Use public keys from keystore Signed-off-by: cyc60 <avsysoev60@gmail.com> * Fix tests Signed-off-by: cyc60 <avsysoev60@gmail.com> --------- Signed-off-by: cyc60 <avsysoev60@gmail.com>

Signed-off-by: cyc60 <avsysoev60@gmail.com>

* Add non finalized validators to funding Signed-off-by: cyc60 <avsysoev60@gmail.com> * Update types Signed-off-by: cyc60 <avsysoev60@gmail.com> --------- Signed-off-by: cyc60 <avsysoev60@gmail.com>

Signed-off-by: cyc60 <avsysoev60@gmail.com>

* Add checks to consolidation Signed-off-by: cyc60 <avsysoev60@gmail.com> * Review fix Signed-off-by: cyc60 <avsysoev60@gmail.com> --------- Signed-off-by: cyc60 <avsysoev60@gmail.com>

* Withdrawals: filter consolidated balances Signed-off-by: cyc60 <avsysoev60@gmail.com> * Review fix Signed-off-by: cyc60 <avsysoev60@gmail.com> --------- Signed-off-by: cyc60 <avsysoev60@gmail.com>

.github/workflows/docker.yaml

Signed-off-by: cyc60 <avsysoev60@gmail.com> Co-authored-by: Dmitri Tsumak <tsumak.dmitri@gmail.com>

Copilot

Pull Request Overview

Copilot reviewed 105 out of 114 changed files in this pull request and generated 3 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

src/validators/keystores/local.py

src/config/networks.py

src/common/contracts.py

* Update metrics Signed-off-by: cyc60 <avsysoev60@gmail.com> * Use tx blocks Signed-off-by: cyc60 <avsysoev60@gmail.com> --------- Signed-off-by: cyc60 <avsysoev60@gmail.com>

Copilot

Pull Request Overview

Copilot reviewed 105 out of 114 changed files in this pull request and generated 4 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

src/withdrawals/tasks.py

src/validators/tasks.py

src/config/settings.py

src/validators/tasks.py

Signed-off-by: cyc60 <avsysoev60@gmail.com> Co-authored-by: Dmitri Tsumak <tsumak.dmitri@gmail.com>

Copilot

Pull Request Overview

Copilot reviewed 105 out of 114 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

src/validators/tasks.py:1

Variable to_block is used on line 360 but is never defined. It should be await execution_client.eth.get_block_number() based on the function's purpose.

import logging

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

src/validators/relayer.py

* Revert multivault setup Signed-off-by: cyc60 <avsysoev60@gmail.com> * Update fee splitter Signed-off-by: cyc60 <avsysoev60@gmail.com> * Update network check message for nodes Signed-off-by: cyc60 <avsysoev60@gmail.com> * Fix setup remote signer Signed-off-by: cyc60 <avsysoev60@gmail.com> --------- Signed-off-by: cyc60 <avsysoev60@gmail.com>

* Update withdrawal interval logic Signed-off-by: cyc60 <avsysoev60@gmail.com> * Use transaction block Signed-off-by: cyc60 <avsysoev60@gmail.com> * Revert transaction block Signed-off-by: cyc60 <avsysoev60@gmail.com> --------- Signed-off-by: cyc60 <avsysoev60@gmail.com>

Copilot

Pull Request Overview

Copilot reviewed 103 out of 112 changed files in this pull request and generated 5 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

src/withdrawals/typings.py

src/validators/typings.py

src/validators/tasks.py

src/common/credentials.py

src/validators/oracles.py

* Update consolidation oracle request Signed-off-by: cyc60 <avsysoev60@gmail.com> * Resolve review comments * Update src/commands/consolidate.py Co-authored-by: evgeny-stakewise <123374581+evgeny-stakewise@users.noreply.github.com> Signed-off-by: Dmitri Tsumak <tsumak.dmitri@gmail.com> * Revert review fix * Fix if check * Move switch check out from the loop * Remove empty line --------- Signed-off-by: cyc60 <avsysoev60@gmail.com> Signed-off-by: Dmitri Tsumak <tsumak.dmitri@gmail.com> Co-authored-by: Dmitri Tsumak <tsumak.dmitri@gmail.com> Co-authored-by: evgeny-stakewise <123374581+evgeny-stakewise@users.noreply.github.com>

* Simplify validator funding * Fix register endpoint

Copilot

Pull Request Overview

Copilot reviewed 103 out of 112 changed files in this pull request and generated 3 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

src/validators/typings.py

src/validators/tests/factories.py

Copilot

Pull Request Overview

Copilot reviewed 103 out of 112 changed files in this pull request and generated 3 comments.

Comments suppressed due to low confidence (1)

src/config/settings.py:1

The set method has an excessive number of parameters (21+). Consider grouping related parameters into configuration objects or dataclasses to improve maintainability and readability.

from enum import Enum

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

src/common/typings.py

src/validators/tasks.py

src/withdrawals/tasks.py

Signed-off-by: cyc60 <avsysoev60@gmail.com>

Copilot

Pull Request Overview

Copilot reviewed 103 out of 112 changed files in this pull request and generated 2 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

src/validators/keystores/local.py

cyc60 and others added 30 commits June 12, 2025 17:11

Use separate dir for every network (#470)

cc00cf7

* Use separate dir for every network Signed-off-by: cyc60 <avsysoev60@gmail.com> * Review fix Signed-off-by: cyc60 <avsysoev60@gmail.com> --------- Signed-off-by: cyc60 <avsysoev60@gmail.com>

Multivault migration (#471)

d38330f

* Multivault migration Signed-off-by: cyc60 <avsysoev60@gmail.com> * Migration refactoring Signed-off-by: cyc60 <avsysoev60@gmail.com> * Review fixes Signed-off-by: cyc60 <avsysoev60@gmail.com> --------- Signed-off-by: cyc60 <avsysoev60@gmail.com>

Some fixes for v4 flow (#475)

3b00ece

Signed-off-by: cyc60 <avsysoev60@gmail.com>

Merge master into v4

5ac510b

Signed-off-by: cyc60 <avsysoev60@gmail.com>

Merge master into v4

475d1c9

Signed-off-by: cyc60 <avsysoev60@gmail.com>

Restore gwei prefix (#489)

91724ae

Fix typo in vaults (#490)

896a31f

Merge master into v4

97071b5

Signed-off-by: cyc60 <avsysoev60@gmail.com>

Add config properties for keystores (#492)

b9042f0

Signed-off-by: cyc60 <avsysoev60@gmail.com>

Fix vaults parameter validation (#493)

3e359dc

Signed-off-by: cyc60 <avsysoev60@gmail.com>

Rename hot-wallet to wallet (#494)

cc1834b

Signed-off-by: cyc60 <avsysoev60@gmail.com>

Use different validator types depending on the vault version (#495)

23b5f51

Signed-off-by: cyc60 <avsysoev60@gmail.com>

Merge branch 'master' into v4

cc7ceab

Update contracts (#500)

e42bd69

Signed-off-by: cyc60 <avsysoev60@gmail.com>

Rm public keys (#501)

e49f088

* Use public keys from keystore Signed-off-by: cyc60 <avsysoev60@gmail.com> * Fix tests Signed-off-by: cyc60 <avsysoev60@gmail.com> --------- Signed-off-by: cyc60 <avsysoev60@gmail.com>

Fix first validator registration (#502)

841c75a

Signed-off-by: cyc60 <avsysoev60@gmail.com>

Add non finalized validators to funding (#503)

ba54bc3

* Add non finalized validators to funding Signed-off-by: cyc60 <avsysoev60@gmail.com> * Update types Signed-off-by: cyc60 <avsysoev60@gmail.com> --------- Signed-off-by: cyc60 <avsysoev60@gmail.com>

Filter validators by SHARD_COMMITTEE_PERIOD (#504)

ca2be37

Signed-off-by: cyc60 <avsysoev60@gmail.com>

Add checks to consolidation (#505)

2ce53e5

* Add checks to consolidation Signed-off-by: cyc60 <avsysoev60@gmail.com> * Review fix Signed-off-by: cyc60 <avsysoev60@gmail.com> --------- Signed-off-by: cyc60 <avsysoev60@gmail.com>

Withdrawals: filter consolidated balances (#506)

93a144f

* Withdrawals: filter consolidated balances Signed-off-by: cyc60 <avsysoev60@gmail.com> * Review fix Signed-off-by: cyc60 <avsysoev60@gmail.com> --------- Signed-off-by: cyc60 <avsysoev60@gmail.com>

github-advanced-security bot found potential problems Sep 17, 2025

View reviewed changes

.github/workflows/docker.yaml Dismissed Show dismissed Hide dismissed

Fix remote signer (#547)

61388bb

Copilot AI review requested due to automatic review settings September 18, 2025 11:21

Update --validator-type values (#548)

e700bc4

Signed-off-by: cyc60 <avsysoev60@gmail.com> Co-authored-by: Dmitri Tsumak <tsumak.dmitri@gmail.com>

Copilot AI reviewed Sep 18, 2025

View reviewed changes

src/validators/keystores/local.py Show resolved Hide resolved

src/config/networks.py Show resolved Hide resolved

src/common/contracts.py Show resolved Hide resolved

cyc60 and others added 2 commits September 18, 2025 18:39

Update metrics (#549)

8e776e8

* Update metrics Signed-off-by: cyc60 <avsysoev60@gmail.com> * Use tx blocks Signed-off-by: cyc60 <avsysoev60@gmail.com> --------- Signed-off-by: cyc60 <avsysoev60@gmail.com>

Fix remote signer (#551)

22ce8df

Copilot AI review requested due to automatic review settings September 21, 2025 11:08

Copilot AI reviewed Sep 21, 2025

View reviewed changes

src/withdrawals/tasks.py Show resolved Hide resolved

src/validators/tasks.py Show resolved Hide resolved

src/config/settings.py Show resolved Hide resolved

src/validators/tasks.py Show resolved Hide resolved

tsudmi and others added 2 commits September 21, 2025 22:33

Fix validators checker address (#552)

1f33cc7

Check available networks in click validator (#550)

70954d0

Signed-off-by: cyc60 <avsysoev60@gmail.com> Co-authored-by: Dmitri Tsumak <tsumak.dmitri@gmail.com>

Copilot AI review requested due to automatic review settings September 22, 2025 10:48

Copilot AI reviewed Sep 22, 2025

View reviewed changes

src/validators/relayer.py Show resolved Hide resolved

cyc60 added 2 commits September 25, 2025 13:29

Copilot AI review requested due to automatic review settings September 25, 2025 12:51

Copilot AI reviewed Sep 25, 2025

View reviewed changes

src/withdrawals/typings.py Show resolved Hide resolved

src/validators/typings.py Show resolved Hide resolved

src/validators/tasks.py Show resolved Hide resolved

src/common/credentials.py Show resolved Hide resolved

src/validators/oracles.py Show resolved Hide resolved

cyc60 and others added 2 commits September 26, 2025 11:01

Fix funding (#557)

4ad99c6

* Simplify validator funding * Fix register endpoint

Copilot AI review requested due to automatic review settings September 26, 2025 12:57

Copilot AI reviewed Sep 26, 2025

View reviewed changes

src/validators/typings.py Show resolved Hide resolved

src/validators/tests/factories.py Show resolved Hide resolved

src/validators/tests/factories.py Show resolved Hide resolved

Update ValidatorsChecker contract addresses (#558)

3401830

tsudmi marked this pull request as ready for review September 29, 2025 19:32

Copilot AI review requested due to automatic review settings September 29, 2025 19:32

Copilot AI reviewed Sep 29, 2025

View reviewed changes

src/common/typings.py Show resolved Hide resolved

src/validators/tasks.py Show resolved Hide resolved

src/withdrawals/tasks.py Show resolved Hide resolved

Pin chain head for withdrawals (#559)

caad9b5

Signed-off-by: cyc60 <avsysoev60@gmail.com>

tsudmi requested a review from Copilot September 29, 2025 19:45

Copilot AI reviewed Sep 29, 2025

View reviewed changes

src/validators/keystores/local.py Show resolved Hide resolved

src/validators/keystores/local.py Show resolved Hide resolved

tsudmi merged commit ecf00ff into master Sep 29, 2025
9 checks passed

tsudmi deleted the v4 branch September 29, 2025 19:54

Conversation

cyc60 commented Sep 5, 2025

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants