This repository was archived by the owner on Mar 12, 2020. It is now read-only.
Merged
Conversation
…aiton in blockstack.js
* feature/auth-response: fixing exports use tsdx for building change name to @blockstack/keychain
* Use blockstack.js lib alpha npm package.
8 tasks
11 tasks
hstove
approved these changes
Nov 26, 2019
Contributor
hstove
left a comment
There was a problem hiding this comment.
Super late review - sorry! Great work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes leather-io/extension#16
Remove dependency on the Node.js
cryptomodule/polyfill -- replace with native Web Crypto operations in blockstack.js.Also removed the
bip32dependency since it is already a (re-exported) dependency ofbitcoinjs-lib. This prevents any future versioning issues between the two.There are a few relatively expensive cryptographic operations that are performed by internal
bip39andbitcoinjs-libcode -- namely secp256k1 EC ops and sha256/512 hashing. Ideally, these don't account for much of the computational time, since refactoring these are difficult.