Skip to content

Fix SSE endpoint rewrite E2E tests using nonexistent flags #4080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChrisJBurns merged 1 commit into from
Mar 11, 2026
Merged

Fix SSE endpoint rewrite E2E tests using nonexistent flags #4080

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions test/e2e/sse_endpoint_rewrite_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,14 +95,14 @@
"--name", serverName,
"--transport", "sse",
"--endpoint-prefix", endpointPrefix,
"--remote-url", mockSSEServer.URL,
mockSSEServer.URL,
).ExpectSuccess()

Expect(stdout+stderr).To(ContainSubstring(serverName), "Output should mention the server name")

By("Waiting for the proxy to be running")
err := e2e.WaitForMCPServer(config, serverName, 60*time.Second)
Expect(err).ToNot(HaveOccurred(), "Proxy should be running within 60 seconds")

Check failure on line 105 in test/e2e/sse_endpoint_rewrite_test.go

View workflow job for this annotation

GitHub Actions / E2E Tests / E2E Tests Core (proxy) 

It 03/11/26 01:04:34.995

By("Getting the proxy URL")
proxyURL, err := e2e.GetMCPServerURL(config, serverName)
Expand Down Expand Up @@ -224,14 +224,14 @@
"--name", serverName,
"--transport", "sse",
"--trust-proxy-headers",
"--remote-url", mockSSEServer.URL,
mockSSEServer.URL,
).ExpectSuccess()

Expect(stdout + stderr).To(ContainSubstring(serverName))

By("Waiting for the proxy to be running")
err := e2e.WaitForMCPServer(config, serverName, 60*time.Second)
Expect(err).ToNot(HaveOccurred())

Check failure on line 234 in test/e2e/sse_endpoint_rewrite_test.go

View workflow job for this annotation

GitHub Actions / E2E Tests / E2E Tests Core (proxy) 

It 03/11/26 01:05:35.119

By("Getting the proxy URL")
proxyURL, err := e2e.GetMCPServerURL(config, serverName)
Expand Down Expand Up @@ -334,7 +334,7 @@
"--transport", "sse",
"--endpoint-prefix", explicitPrefix,
"--trust-proxy-headers",
"--remote-url", mockSSEServer.URL,
mockSSEServer.URL,
).ExpectSuccess()

Expect(stdout + stderr).To(ContainSubstring(serverName))
Expand Down Expand Up @@ -393,7 +393,7 @@
GinkgoWriter.Printf("SSE stream (priority test):\n%s\n", sseContent)

// Verify explicit prefix was used, not the header value
Expect(sseContent).To(ContainSubstring(fmt.Sprintf("data: %s/sse?sessionId=priority-test-789", explicitPrefix)),

Check failure on line 396 in test/e2e/sse_endpoint_rewrite_test.go

View workflow job for this annotation

GitHub Actions / E2E Tests / E2E Tests Core (proxy) 

It 03/11/26 01:05:36.367
"Should use explicit --endpoint-prefix, not X-Forwarded-Prefix header")
Expect(sseContent).ToNot(ContainSubstring(headerPrefix),
"Should NOT use X-Forwarded-Prefix when explicit prefix is configured")
Expand All @@ -419,7 +419,7 @@
endpointPrefix := "/api/mcp"

// Check if osv server is available in registry
stdout, _ := e2e.NewTHVCommand(config, "list", "--registry").ExpectSuccess()
stdout, _ := e2e.NewTHVCommand(config, "registry", "list").ExpectSuccess()
if !strings.Contains(stdout, "osv") {
Skip("OSV server not available in registry")
}
Expand All @@ -443,7 +443,7 @@

By("Waiting for MCP server to be ready")
err = e2e.WaitForMCPServerReady(config, serverURL, "sse", 2*time.Minute)
Expect(err).ToNot(HaveOccurred())

Check failure on line 446 in test/e2e/sse_endpoint_rewrite_test.go

View workflow job for this annotation

GitHub Actions / E2E Tests / E2E Tests Core (proxy) 

It 03/11/26 01:07:39.436

By("Connecting to SSE endpoint and checking for endpoint event")
parsedURL, err := url.Parse(serverURL)
Expand Down
Loading