Resolve locally-built artifacts during skill install#4018
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4018 +/- ##
==========================================
- Coverage 68.60% 68.55% -0.06%
==========================================
Files 444 444
Lines 45184 45219 +35
==========================================
Hits 31000 31000
- Misses 11783 11822 +39
+ Partials 2401 2397 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
reyortiz3
previously approved these changes
Mar 5, 2026
When a user runs `thv skill build` followed by `thv skill install <name>`, the install now checks the local OCI store for a tag matching the skill name before falling back to a pending record. This unblocks the local dev workflow (build → install) where the artifact is already available locally. The new resolveFromLocalStore method validates the artifact's embedded name matches the install name (supply-chain defense), extracts layer data and metadata, and hydrates the install options so the existing installWithExtraction flow handles the rest. Closes #4015 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
39ca570 to
c81435a
Compare
aponcedeleonch
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resolveFromLocalStoremethod to check the local OCI store for a tag matching the skill name before creating a pending record duringthv skill install <name>thv skill build ./my-skillthenthv skill install my-skillnow produces an "installed" (not "pending") skillChanges
pkg/skills/skillsvc/skillsvc.goresolveFromLocalStoremethod; modifiedInstallto check local store before pending fallbackpkg/skills/skillsvc/skillsvc_test.goTestInstallFromLocalStore— 5 table-driven cases (happy path, name mismatch, tag not found, nil store, corrupt manifest)test/e2e/api_skills_test.goTest plan
task lint-fix— 0 issuestask test— all unit tests passtask test-e2e— E2E tests (new build-then-install cases)thv skill build ./skill-dir && thv skill install <name>produces status "installed"Closes #4015
🤖 Generated with Claude Code