Refactor session timeouts and add V2 feature warnings#3974
Conversation
There was a problem hiding this comment.
Pull request overview
Refactors session-storage operation timeouts into named constants and adds startup-time operator warnings when SessionManagementV2 is enabled alongside currently-unsupported features, to avoid silent feature loss.
Changes:
- Extracted hardcoded 5s/30s
context.WithTimeoutdurations intransportsession.Managerinto package-level constants. - Added startup warnings when
SessionManagementV2is enabled with optimizer mode and/or composite tools configured.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
pkg/vmcp/server/server.go |
Emits startup warnings for unsupported feature combinations when SessionManagementV2 is enabled. |
pkg/transport/session/manager.go |
Replaces repeated hardcoded timeout literals with named constants for readability/maintainability. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Extract hardcoded timeout values in session manager into package-level constants for better maintainability. Add startup warnings when SessionManagementV2 is configured with incompatible features. Changes: - pkg/transport/session: Extract 5s and 30s timeouts to named constants (defaultOperationTimeout and cleanupOperationTimeout) to improve readability and make adjustments easier - pkg/vmcp/server: Warn operators at startup when SessionManagementV2 is enabled alongside unsupported features (optimizer mode, composite tools) to provide early feedback instead of silent feature loss Addresses PR review feedback from @aponcedeleonch. Closes: #3866
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3974 +/- ##
==========================================
- Coverage 68.13% 68.11% -0.02%
==========================================
Files 437 437
Lines 44337 44363 +26
==========================================
+ Hits 30208 30217 +9
- Misses 11782 11791 +9
- Partials 2347 2355 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Extract hardcoded timeout values in session manager into package-level constants for better maintainability. Add startup warnings when SessionManagementV2 is configured with incompatible features.
Changes:
Addresses PR review feedback from @aponcedeleonch.
Closes: #3866