Summary

This PR introduces comprehensive validation for registry configurations and structured error types for better error handling and classification.

This is part 1 of 3 PRs that improve registry API error handling:

1. This PR: Add validation infrastructure and error types
2. Introduce service layer and improve API/CLI error handling
3. Update E2E tests

Changes

Validation Infrastructure

• Add 5-second timeout support to HTTP client builder (pkg/networking/http_client.go)
• Add registry validation functions in pkg/registry/provider_remote.go:
  • isValidRegistryJSON(): Validates registry JSON structure
  • registryHasServers(): Ensures registry contains at least one server
• Add comprehensive validation tests in pkg/registry/provider_test.go

Structured Error Types

• Introduce new error types in pkg/config/errors.go:
  • RegistryError: Wraps registry errors with context (type, URL)
  • ErrRegistryTimeout: Sentinel error for timeout scenarios
  • ErrRegistryUnreachable: Sentinel error for connectivity issues
  • ErrRegistryValidationFailed: Sentinel error for validation failures
• Add error tests in pkg/config/errors_test.go

Error Classification

• Add classifyNetworkError() in pkg/config/registry.go to classify network errors
• Update setRegistryURL(), setRegistryFile(), setRegistryAPI() to return RegistryError types
• Update tests to reflect new error handling

Benefits

1. Better error context: Errors now include registry type and URL
2. Structured error handling: Can use errors.Is() and errors.As() for error inspection
3. Foundation for proper HTTP status codes: Enables mapping to 502 (validation) and 504 (timeout)
4. Improved user experience: Downstream changes can provide better error messages

Testing

• Added comprehensive unit tests for validation logic
• Added error classification tests
• Updated existing tests to work with new error types

🤖 Generated with Claude Code