Composite Tools: Fix plumbing for on-error-continue config#3118
Merged
Composite Tools: Fix plumbing for on-error-continue config#3118
Conversation
Signed-off-by: Jeremy Drouillard <jeremy@stacklok.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3118 +/- ##
=======================================
Coverage 57.11% 57.11%
=======================================
Files 341 341
Lines 33949 33950 +1
=======================================
+ Hits 19389 19390 +1
Misses 12951 12951
Partials 1609 1609 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rdimitrov
approved these changes
Dec 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix a bug where broken config plumbing lead to ignored continue-on-error behavior in composite tools.
Details
While preparing for a demo of continue-on-error behavior, I encountered a surprising bug where my config for a skippable step was not respected.
Instead, the composite tool aborted.
Root Cause
This was a surprising bug, because I know an integration test exists. Upon closer inspection, you'll see our integration tests bypass much of our configuration plumbing, previously described here. The composite tools system is even more elaborate, since it has another step:
CRD config -> yaml -> rawConfig -> config -> data structures used in executionThe linked integration tests configures
data structures used in execution, so it missed the brokenconfig -> data structures used in executionstep.I chose not to write a regression test for this quick fix. Instead, I will be opening an issue that describes the systemic issue and breakdown the work to repair it.