Merged
Conversation
Signed-off-by: ChrisJBurns <29541485+ChrisJBurns@users.noreply.github.com>
Signed-off-by: ChrisJBurns <29541485+ChrisJBurns@users.noreply.github.com>
Signed-off-by: ChrisJBurns <29541485+ChrisJBurns@users.noreply.github.com>
JAORMX
reviewed
Apr 25, 2025
Signed-off-by: ChrisJBurns <29541485+ChrisJBurns@users.noreply.github.com>
JAORMX
reviewed
Apr 25, 2025
Signed-off-by: ChrisJBurns <29541485+ChrisJBurns@users.noreply.github.com>
Signed-off-by: ChrisJBurns <29541485+ChrisJBurns@users.noreply.github.com>
JAORMX
reviewed
Apr 28, 2025
| }, | ||
| } | ||
|
|
||
| logsCommand.Flags().BoolVarP(&tailFlag, "tail", "t", false, "Tail the logs") |
Collaborator
There was a problem hiding this comment.
should we make this an IntVarP and pass the 100 that's the default?
Collaborator
Author
There was a problem hiding this comment.
Not sure if we can make 100 the default here as that would mean it always tails 100 lines. We need a flag that allows users to tail or just output. However, I can add another variable that is an IntVarP that defaults to 100 and instead outputs the last 100 lines OR it will only tail the last 100 lines.
Signed-off-by: ChrisJBurns <29541485+ChrisJBurns@users.noreply.github.com>
JAORMX
approved these changes
May 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previous to this PR, there was no way of tailing the logs, you had to continually run
thv logs $SERVER_NAMEto get the logs. Now, with the addition of the-tflag tothv logs $SERVER_NAMEwe can tail the last 100 log lines. If we want to make the100configurable, we can, thought I'd set a sensible default for now.Changes
-ttail flag to the logs subcommandRunEso we can return errors from the subcommands up to the mainRef: #202