feat: connect logger up to debug flag allowing to enable/disable debug logging#277
Merged
ChrisJBurns merged 1 commit intomainfrom Apr 25, 2025
Merged
feat: connect logger up to debug flag allowing to enable/disable debug logging#277ChrisJBurns merged 1 commit intomainfrom
ChrisJBurns merged 1 commit intomainfrom
Conversation
Signed-off-by: ChrisJBurns <29541485+ChrisJBurns@users.noreply.github.com>
3c3e55f to
4448b38
Compare
JAORMX
approved these changes
Apr 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR connects the global
--debugflag up to our logger. Now, if you pass in--debugyou will get debug logs. It is false by default which results in INFO level logging and above (WARN, ERROR)Changes
PersistentPreRunso that we initialise the logger before the rest of the code is run.commands.goso that it can utilise the logger. If left in main, it will use an uninitialised loggerRef: #142