Fix StatefulSet container configuration in Kubernetes runtime#275
Merged
Fix StatefulSet container configuration in Kubernetes runtime#275
Conversation
This change fixes an issue where StatefulSets created for MCP servers in the Kubernetes runtime were missing container configuration. The problem was in the getMCPContainer function, which was not properly handling the container list. The fix simplifies the container handling by directly using WithContainers to add the new container, which properly appends it to the existing containers list. This resolves the issue where StatefulSets were being created with empty containers.
ChrisJBurns
approved these changes
Apr 25, 2025
This change fixes an issue where StatefulSets created for MCP servers in the Kubernetes runtime were missing container configuration. The problem was in the getMCPContainer function, which was not properly handling the container list. The fix: 1. Modified getMCPContainer to return nil if the container doesn't exist 2. Added configureMCPContainer function to handle container configuration 3. Added comprehensive tests for both functions 4. Added a constant for the MCP container name This resolves the issue where StatefulSets were being created with empty containers.
Signed-off-by: Juan Antonio Osorio <ozz@stacklok.com>
ChrisJBurns
approved these changes
Apr 25, 2025
This was referenced Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where StatefulSets created for MCP servers in the Kubernetes runtime were missing container configuration. The problem was in the
getMCPContainerfunction, which was not properly handling the container list.Changes
getMCPContainerfunction to properly handle container listsWithContainersto add the new containerTesting
All tests are passing, including the new tests for the
getMCPContainerfunction.