fix: fixes the lack of fallback to docker#270
Merged
ChrisJBurns merged 4 commits intomainfrom Apr 24, 2025
Merged
Conversation
there were errors when trying to ping the podman runtime when there is a socketpath detected. this commit ensures that if there is a failure in the ping to the runtime, it will skip to the next eligible runtime (docker in this case) Signed-off-by: ChrisJBurns <29541485+ChrisJBurns@users.noreply.github.com>
Signed-off-by: ChrisJBurns <29541485+ChrisJBurns@users.noreply.github.com>
Signed-off-by: ChrisJBurns <29541485+ChrisJBurns@users.noreply.github.com>
Signed-off-by: ChrisJBurns <29541485+ChrisJBurns@users.noreply.github.com>
JAORMX
approved these changes
Apr 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were errors when trying to ping the podman runtime when there is a socketpath detected. This PR ensures that if there is a failure in the ping to the runtime, it will skip to the next eligible runtime (docker in this case).
I've made sure to:
err != nilcode paths in the socketpath checks because we were swallowing them by only executing code on theerr == nilcases. this allows us to log the reasons why it failed.Screenshot of
thvfinding a Podman socketpath, trying to connect to it (because I've stopped it), failing, and trying docker instead, which resulted in a successful connection.Ref: #260