Skip to content

Fix nil pointer dereference in environment variable validation #2252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JAORMX merged 7 commits into from
Oct 18, 2025
Merged

Fix nil pointer dereference in environment variable validation #2252

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
de7436c
Fix nil pointer dereference in environment variable validation
kofort9 Oct 15, 2025
6bea5f5
Fix formatting: remove extra blank line
kofort9 Oct 16, 2025
2dfbe61
Apply suggestion from @Copilot
kofort9 Oct 18, 2025
1f7371a
Improve log message for nil secrets manager
kofort9 Oct 18, 2025
584ee16
Fix line length for log message
kofort9 Oct 18, 2025
e36f7af
Merge branch 'main' into fix/env-var-nil-pointer-1469
kofort9 Oct 18, 2025
9f66c56
Update pkg/runner/env.go
kofort9 Oct 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 14 additions & 5 deletions pkg/runner/env.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,13 +114,22 @@ func (v *CLIEnvVarValidator) Validate(
if envVar.Required {

if envVar.Secret {
value, err := secretsManager.GetSecret(ctx, envVar.Name)
if err != nil {
logger.Warnf("Unable to find secret %s in the secrets manager: %v", envVar.Name, err)
// Check if secrets manager is available before attempting to retrieve secret.
// Falls back to prompt if unavailable or secret not found.
if secretsManager != nil {
value, err := secretsManager.GetSecret(ctx, envVar.Name)
if err != nil {
logger.Warnf("Unable to find secret %s in the secrets manager: %v", envVar.Name, err)
} else {
addNewVariable(ctx, envVar, value, secretsManager, &envVars, &secretsList)
continue
}
} else {
addNewVariable(ctx, envVar, value, secretsManager, &envVars, &secretsList)
continue
logger.Warnf("Secrets manager not configured (setup incomplete or missing provider) - " +
"falling back to prompt")
}

// If secrets manager unavailable or secret not found, fall through to prompt
}

value, err := promptForEnvironmentVariable(envVar)
Expand Down
Loading