Fix OTel insecure and prometheus settings fallback to global config#1900
Merged
Fix OTel insecure and prometheus settings fallback to global config#1900
Conversation
Signed-off-by: Dan Barr <6922515+danbarr@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1900 +/- ##
==========================================
+ Coverage 45.77% 46.39% +0.62%
==========================================
Files 203 206 +3
Lines 25979 26145 +166
==========================================
+ Hits 11891 12131 +240
+ Misses 13173 13094 -79
- Partials 915 920 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Add fallback logic for OtelEnablePrometheusMetricsPath in getTelemetryFromFlags() - Update function signature to handle the additional parameter - Enhanced tests to verify prometheus metrics path fallback behavior Same issue as the insecure setting - was being passed directly without checking the global config fallback.
Signed-off-by: Dan Barr <6922515+danbarr@users.noreply.github.com>
Signed-off-by: Dan Barr <6922515+danbarr@users.noreply.github.com>
ChrisJBurns
approved these changes
Sep 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1899
The
insecureandenable-prometheus-metrics-pathconfigs were not falling back to the global config file settings when the CLI flags aren't provided as overrides. This caused ToolHive to:thv config otel set-insecure truewas configuredthv config otel set-enable-prometheus-metrics-path truewas configuredChanges:
insecureandenable-prometheus-metrics-pathsettings ingetTelemetryFromFlags()NOTE: this issue also affects the
metrics-enabledandtracing-enabledflags that were also added in #1785, but since these default totrue, I had trouble solving for them in the same way, since unset and explicitfalseconfig settings are currently indistinguishable.