-
Notifications
You must be signed in to change notification settings - Fork 198
Scoped secret store: migration infrastructure for existing keys #4226
Copy link
Copy link
Open
Labels
authenticationenhancementNew feature or requestNew feature or requestgoPull requests that update go codePull requests that update go code
Description
Summary
Phase 3 of the scoped secret store implementation (#4192).
Existing users may have registry tokens and workload auth secrets stored under bare keys (no __thv_ prefix). This phase adds crash-safe migration infrastructure to rename them into the correct scope on first run.
Work
MigrateSystemKeys(ctx, provider, migrations []KeyMigration) errorinmigration.go- Uses
BulkDeleteSecrets(store-before-delete ordering) so a crash mid-migration does not leave secrets unreachable - Guarded by a config flag so migration only runs once
- Unit tests covering full migration, partial failure, and idempotency
Dependencies
Depends on Phase 2. Must ship together with Phase 4 (wire callers) — shipping migration without updated callers, or updated callers without migration, would break existing users.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
authenticationenhancementNew feature or requestNew feature or requestgoPull requests that update go codePull requests that update go code