-
Notifications
You must be signed in to change notification settings - Fork 198
Global OTel settings are not applied to servers started via API/UI #2295
Copy link
Copy link
Open
Labels
apiItems related to the APIItems related to the APIbugSomething isn't workingSomething isn't workingcliChanges that impact CLI functionalityChanges that impact CLI functionalitytelemetry
Description
Bug description
The "global" OpenTelemetry settings (those set using thv config otel set-* are not being applied to servers that are started using the UI/API.
This is a gap for CLI/UI coexistence for users who desire to push a standardized telemetry configuration.
Steps to reproduce
Set some OTel settings:
thv config otel set-enable-prometheus-metrics-path true
thv config otel set-endpoint localhost:4318
thv config otel set-insecure true
thv config otel set-sampling-rate 1.0
# etc...
Then run a server from the UI, and examine the runconfig. No telemetry_config section is included, and no traces/metrics are emitted. But running a server using the CLI, the settings are applied as expected.
Expected behavior
The global telemetry settings from the config file should be applied.
Actual behavior
The telemetry settings are not applied.
Environment (if relevant)
- ToolHive version: v0.4.0
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
apiItems related to the APIItems related to the APIbugSomething isn't workingSomething isn't workingcliChanges that impact CLI functionalityChanges that impact CLI functionalitytelemetry