Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: stacklok/go-microvm
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.0.22
Choose a base ref
...
head repository: stacklok/go-microvm
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.0.23
Choose a head ref
  • 2 commits
  • 3 files changed
  • 2 contributors

Commits on Mar 17, 2026

  1. Fix SSH agent forwarding handled in wrong request handler 

    Move auth-agent-req@openssh.com handling from handleGlobalRequests
(SSH_MSG_GLOBAL_REQUEST) to handleSession (SSH_MSG_CHANNEL_REQUEST),
matching the SSH spec and what real clients like Go's
agent.RequestAgentForwarding() actually send.

The old handler was dead code — real clients send this as a session
channel request, which hit the default reject case in handleSession.
Tests passed only because they used client.SendRequest() (global)
instead of session-scoped requests.

Tests now use agent.RequestAgentForwarding(session) to exercise the
correct code path, including a same-session end-to-end test that
verifies SSH_AUTH_SOCK is set.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
    @JAORMX @claude
    JAORMX and claude committed Mar 17, 2026
    Configuration menu
    Copy the full SHA
    db3efd1 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #46 from stacklok/fix/agent-forwarding-channel-req… 

    …uest

Fix SSH agent forwarding handled in wrong request handler
    @JAORMX
    JAORMX authored Mar 17, 2026
    Configuration menu
    Copy the full SHA
    8a4bc2e View commit details
    Browse the repository at this point in the history
Loading