Remove private module token from CI workflows#79
Merged
Conversation
go-microvm is now OSS — the GO_MODULE_TOKEN secret and GOPRIVATE env var are no longer needed. Use the built-in github.token for gh release downloads and drop the git URL rewrite steps. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The test created independent repos via initRepo() for both snapshot and original, giving them different initial commit hashes. The divergence guard (originalHEAD != baseRef) triggered, returning Skipped=0 before any commit processing. Clone the snapshot repo instead so both share the same base commit, matching the pattern used by all other replay tests. Also fix TestReplay_NoNewCommits which had the same bug but happened to pass because the divergence guard returns the same zero values the test asserts. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GOPRIVATEenv var andGO_MODULE_TOKENsecret usage from CI and Release workflowsGH_TOKENwith the built-ingithub.token(sufficient for public repo access)go-microvm is now open source, so the private module token is no longer needed. The token was causing 401 errors in CI (
fetch-runtime→gh release download) because the secret has bad/expired credentials.Test plan
fetch-runtime→gh release downloadstep usesgithub.token)GOPRIVATE)GO_MODULE_TOKENin workflows🤖 Generated with Claude Code