Fix config merge: global defaults now override agent built-ins#78
Merged
Fix config merge: global defaults now override agent built-ins#78
Conversation
The Merge() function had a `result.DefaultXxx == 0 &&` guard that prevented global config defaults from overriding non-zero agent built-in values. Since all built-in agents define non-zero defaults, the `defaults:` config section was effectively dead code. Remove the guard so precedence is: override > global default > agent default. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Tests guard the fix where global defaults now override non-zero agent built-in resource values. Covers per-field independence, clamping of global defaults, and orthogonality with egress profile tightening. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Merge()function had aresult.DefaultXxx == 0 &&guard that prevented global config defaults from overriding non-zero agent built-in values for CPUs, Memory, and TmpSize. Since all built-in agents define non-zero defaults, thedefaults:config section was effectively dead code. Remove the guard so precedence is: override > global default > agent default.Test plan
TestMerge*tests pass🤖 Generated with Claude Code