Merged
Conversation
67daf26 to
d9048a5
Compare
Merged
2 tasks
Toolhive v0.12.2 made SessionFactory a required field on vmcpserver.Config. Wire a session factory into the VMCPProvider so the vmcp server can be created successfully again. Add an integration test that verifies Services() end-to-end against a live ToolHive instance, and a CI job that provisions one via toolhive-actions. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
d9048a5 to
dcf30b3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SessionFactorya required field onvmcpserver.Config. The VMCPProvider wasn't setting it, causingServices()to fail with"SessionFactory is required but was not provided"— surfaced as "MCP unavailable, continuing without MCP support".provider_integration_test.gothat callsServices()end-to-end against a live ToolHive instance, covering all built-in authz profiles. Skips gracefully whenthvis absent or no servers are running.integration-testjob provisions ToolHive and a fetch MCP server viatoolhive-actionsso the integration test runs on every PR.Test plan
task test— all existing tests passtask lint— no issuesbbox claude-coderun confirms MCP tools are discovered🤖 Generated with Claude Code