Add selector flag

Cornelius Weig · Cornelius Weig · commit 790bded0cec3 · 2019-04-13T01:10:07.000+02:00
diff --git a/cmd/root.go b/cmd/root.go
@@ -92,6 +92,7 @@ func init() {
 	rootCmd.Flags().BoolVar(&ketallOptions.UseCache, constants.FlagUseCache, false, "use cached list of server resources")
 	rootCmd.Flags().StringVar(&ketallOptions.Scope, constants.FlagScope, "", "only resources with scope cluster|namespace")
 	rootCmd.Flags().StringVar(&ketallOptions.Since, constants.FlagSince, "", "only resources younger than given age")
+	rootCmd.Flags().StringVarP(&ketallOptions.Selector, constants.FlagSelector, "l", "", "selector (label query) to filter on, supports '=', '==', and '!='.(e.g. -l key1=value1,key2=value2)")
 	rootCmd.Flags().StringSliceVar(&ketallOptions.Exclusions, constants.FlagExclude, []string{"events"}, "filter by resource name (plural form or short name)")
 
 	ketallOptions.GenericCliFlags.AddFlags(rootCmd.Flags())
diff --git a/pkg/ketall/client/client.go b/pkg/ketall/client/client.go
@@ -143,15 +143,21 @@ func fetchResourcesBulk(flags resource.RESTClientGetter, resourceTypes ...groupR
 
 	request := resource.NewBuilder(flags).
 		Unstructured().
-		SelectAllParam(true).
 		ResourceTypes(resourceNames...).
 		Latest()
+
 	if ns := viper.GetString(constants.FlagNamespace); ns != "" {
 		request.NamespaceParam(ns)
 	} else {
 		request.AllNamespaces(true)
 	}
 
+	if selector := viper.GetString(constants.FlagSelector); selector != "" {
+		request.LabelSelectorParam(selector)
+	} else {
+		request.SelectAllParam(true)
+	}
+
 	return request.Do().Object()
 }
 
diff --git a/pkg/ketall/constants/constants.go b/pkg/ketall/constants/constants.go
@@ -26,4 +26,5 @@ const (
 	FlagScope     = "only-scope"
 	FlagSince     = "since"
 	FlagUseCache  = "use-cache"
+	FlagSelector  = "selector"
 )
diff --git a/pkg/ketall/options/options.go b/pkg/ketall/options/options.go
@@ -33,6 +33,7 @@ type KetallOptions struct {
 	UseCache        bool
 	Scope           string
 	Since           string
+	Selector        string
 	Exclusions      []string
 	Streams         *genericclioptions.IOStreams
 }

Original file line number	Diff line number	Diff line change
`@@ -26,4 +26,5 @@ const (`
`26`	`26`	`FlagScope = "only-scope"`
`27`	`27`	`FlagSince = "since"`
`28`	`28`	`FlagUseCache = "use-cache"`
	`29`	`+ FlagSelector = "selector"`
`29`	`30`	`)`
Original file line number	Diff line number	Diff line change
`@@ -33,6 +33,7 @@ type KetallOptions struct {`
`33`	`33`	`UseCache bool`
`34`	`34`	`Scope string`
`35`	`35`	`Since string`
	`36`	`+ Selector string`
`36`	`37`	`Exclusions []string`
`37`	`38`	`Streams *genericclioptions.IOStreams`
`38`	`39`	`}`