Skip to content

Commit 3ede201

Browse files
committed
Allow fully-qualified resource names to be used with --exclude
Signed-off-by: Mehran Kholdi <semekh@hamravesh.com>
1 parent 3e2dc04 commit 3ede201

2 files changed

Lines changed: 8 additions & 0 deletions

File tree

internal/client/client.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -142,6 +142,7 @@ func extractRelevantResources(grs []groupResource, exclusions []string) []groupR
142142
name := r.fullName()
143143
resourceIds := r.APIResource.ShortNames
144144
resourceIds = append(resourceIds, r.APIResource.Name)
145+
resourceIds = append(resourceIds, name)
145146
if forbidden.HasAny(resourceIds...) {
146147
logrus.Debugf("Excluding %s", name)
147148
continue

internal/client/client_test.go

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,13 @@ func TestExtractRelevantResourceNames(t *testing.T) {
6363
exclude: []string{"baz"},
6464
expected: []string{"bar.puorg"},
6565
},
66+
{
67+
testName: "two filtered by fully-qualified resource name",
68+
resources: []v1.APIResource{{Name: "foo"}, {Name: "bar"}},
69+
groups: []string{"group", "puorg"},
70+
exclude: []string{"foo.group"},
71+
expected: []string{"bar.puorg"},
72+
},
6673
}
6774

6875
for _, test := range tests {

0 commit comments

Comments
 (0)