Skip to content

2024 update#49

Merged
ssut merged 1 commit into
ssut:mainfrom
nezorflame:main
Jul 19, 2024
Merged

2024 update#49
ssut merged 1 commit into
ssut:mainfrom
nezorflame:main

Conversation

@nezorflame

Copy link
Copy Markdown
Contributor
  • update dependencies
  • update Go version to 1.18 (to support new deps)
  • regenerate proto-generated file with the latest protoc_gen_go
  • fix linter issues with the latest golangci-lint

- update dependencies
- update Go version to 1.18 (to support new deps)
- regenerate proto-generated file with the latest `protoc_gen_go`
- fix linter issues with the latest `golangci-lint`
Comment thread .gitignore
Comment thread go.mod
Comment thread go.mod
Comment thread main.go
Comment thread payload.go
Comment thread payload.go
@ssut ssut self-requested a review July 17, 2024 14:53
@ssut

ssut commented Jul 19, 2024

Copy link
Copy Markdown
Owner

Thank you for your contribution! I'll merge this soon and then do some further works on the main branch after just merged.

Comment thread go.mod
@nezorflame

Copy link
Copy Markdown
Contributor Author

Thank you for your contribution! I'll merge this soon and then do some further works on the main branch after just merged.

No worries! If you want, I can also add linter configuration and adapt the builds to use it.

@ssut

ssut commented Jul 19, 2024

Copy link
Copy Markdown
Owner

Thank you for your contribution! I'll merge this soon and then do some further works on the main branch after just merged.

No worries! If you want, I can also add linter configuration and adapt the builds to use it.

I'd really appreciate it if you can.

@ssut

ssut commented Jul 19, 2024

Copy link
Copy Markdown
Owner

By the way, I'm planning to separate packages into cmd and payload (the name is not decided yet though). Do you think this work would make sense for the payload-dumper-go project? I'm just asking for your opinion/advice.

@ssut

ssut commented Jul 19, 2024

Copy link
Copy Markdown
Owner

Now that I’m going to merge this PR for the further works I’ve planned. Thanks again for your contribution. Please feel free to open a new pull request if you’d like to submit or improve more things.

@ssut ssut merged commit efc0ae4 into ssut:main Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants