Skip to content

Conversation

@A248
Copy link
Contributor

@A248 A248 commented Jul 26, 2025

The line number starts from 0 reflecting how it is used in the parser

@brett-smith
Copy link
Contributor

Thanks for the PR. Could I ask you make a small change. The various INIReader.read() methods should probably now throw INIParseException instead of ParseException, and Javadocs updated accordingly. This may break backwards compatibility for some users using INIReader directly, so I'll hold off merging this until 0.6.0-SNAPSHOT . I 'll merge your other PR and another minor typo into 0.5.6-SNAPSHOT before this though.

The convenience from*() methods in INI should now catch INIParseException and rethrow IllegalStateException instead.

@A248
Copy link
Contributor Author

A248 commented Jul 28, 2025

I made the changes requested.

I will note that this PR is fully compatible with existing code. INIParseException extends ParseException, meaning that old catch blocks will still work. Narrowing the type of a thrown exception, from a method inside a final class, is never a contractually incompatible change.

@brett-smith brett-smith merged commit 73e3aa0 into sshtools:main Aug 18, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants