Conversation
Problem: Travis was set up using ancient versions of Node that don't work anymore, so the tests were constantly failing. Solution: Use the latest Node.js version by default.
Problem: When an HTTP(S) link is present in the text, SSB-Mentions seems to be adding `null` as a mention, which is causing bugs downstream. Solution: Never add `null` to the mentions array and add a test to ensure that this never happens.
Contributor
Author
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: When an HTTP(S) link is present in the text, SSB-Mentions seems
to be adding
nullas a mention, which is causing bugs downstream.Solution: Never add
nullto the mentions array and add a test toensure that this never happens.
Includes #16
Should resolve ssbc/patchwork#1248