Use Millisecs from go-ssb-refs#325
Merged
decentral1se merged 1 commit intossbc:masterfrom Feb 11, 2023
Merged
Conversation
decentral1se
approved these changes
Feb 10, 2023
decentral1se
requested changes
Feb 11, 2023
Member
There was a problem hiding this comment.
Aha, woops, the CI build is claiming this error:
Error: ../../../go/pkg/mod/github.com/ssbc/go-metafeed@v1.1.3-0.20221019090205-458925e39156/message.go:222:18: cannot use encodedTime.Millisecs(msg.Claimed()) (value of type encodedTime.Millisecs) as type refs.Millisecs in assignment
https://github.com/ssbc/go-ssb/actions/runs/4145009524/jobs/7176788615
I guess we just need to merge ssbc/go-metafeed#30 also and update here too? WIll take a look.
Contributor
Author
|
Oh yeah we need to merge (and optionally tag) that dependency first. My bad. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #324.