Skip to content

Fix TestPeople#322

Merged
decentral1se merged 2 commits intossbc:masterfrom
KyleMaas:fix-testpeople-simplified
Feb 5, 2023
Merged

Fix TestPeople#322
decentral1se merged 2 commits intossbc:masterfrom
KyleMaas:fix-testpeople-simplified

Conversation

@KyleMaas
Copy link
Copy Markdown
Contributor

@KyleMaas KyleMaas commented Feb 2, 2023

Fixes #274

Ran successfully over 1000 times. Then I went back, cleaned up the extra logging code I used to trace it, and simplified it and ran it a few more times successfully.

That was a massive pain to track down.

@KyleMaas
Copy link
Copy Markdown
Contributor Author

KyleMaas commented Feb 3, 2023

Forgot to re-enable the test for CI.

@KyleMaas KyleMaas mentioned this pull request Feb 5, 2023
Copy link
Copy Markdown
Member

@decentral1se decentral1se left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏

@decentral1se decentral1se merged commit 5d4c6a9 into ssbc:master Feb 5, 2023
@decentral1se decentral1se mentioned this pull request Feb 5, 2023
25 tasks
@KyleMaas
Copy link
Copy Markdown
Contributor Author

KyleMaas commented Feb 6, 2023

Thanks!

@KyleMaas KyleMaas deleted the fix-testpeople-simplified branch February 6, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TestPeople is really, really broken

2 participants