Skip to content

Fix TestIndexFixtures#280

Merged
decentral1se merged 2 commits intossbc:masterfrom
KyleMaas:fix-test-index-fixtures
Dec 27, 2022
Merged

Fix TestIndexFixtures#280
decentral1se merged 2 commits intossbc:masterfrom
KyleMaas:fix-test-index-fixtures

Conversation

@KyleMaas
Copy link
Copy Markdown
Contributor

Ran successfully 22 times without errors. This one takes a while to run.

Fixes #279

See also #237

@decentral1se
Copy link
Copy Markdown
Member

That's strange, it's failing with the same error reported in #279 🤔

@decentral1se decentral1se mentioned this pull request Dec 26, 2022
25 tasks
@KyleMaas
Copy link
Copy Markdown
Contributor Author

I think I found the problem. Upon closer inspection, I noticed I had a file not added to git. Turns out the test's download script would fail with an error code of 0 (success) the first time you ran it, but would run just fine on subsequent runs, which is why it worked for me. But since the CI system is always starting from a blank slate, it was neither working correctly (failing) nor failing out the script where it would log the output (returning 0). This latest commit should fix that.

Copy link
Copy Markdown
Member

@decentral1se decentral1se left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thanks!

@decentral1se decentral1se merged commit 3ce06b7 into ssbc:master Dec 27, 2022
@KyleMaas
Copy link
Copy Markdown
Contributor Author

Thanks!

@KyleMaas KyleMaas deleted the fix-test-index-fixtures branch December 28, 2022 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TestIndexFixtures test is failing

2 participants