Skip to content

Fix TestMigrate#264

Merged
decentral1se merged 1 commit intossbc:masterfrom
KyleMaas:try-to-fix-migrate-test
Dec 18, 2022
Merged

Fix TestMigrate#264
decentral1se merged 1 commit intossbc:masterfrom
KyleMaas:try-to-fix-migrate-test

Conversation

@KyleMaas
Copy link
Copy Markdown
Contributor

Fixes the TestMigrate test by detecting the error condition of a closed log and not erroring out at the live feed layer. Ran successfully 238 times.

Fixes #257

See also #237

@KyleMaas
Copy link
Copy Markdown
Contributor Author

I think this might also have been the core of the:

(Sometimes the gossip test blocks indefinitely. This is a bug in go-muxrpcs closing behavior. See the FAQ for more information.)

Mentioned in the README

Copy link
Copy Markdown
Member

@decentral1se decentral1se left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌟

@decentral1se decentral1se merged commit 7bd9543 into ssbc:master Dec 18, 2022
@decentral1se decentral1se mentioned this pull request Dec 18, 2022
25 tasks
@KyleMaas
Copy link
Copy Markdown
Contributor Author

Thanks!

@KyleMaas KyleMaas deleted the try-to-fix-migrate-test branch December 19, 2022 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

TestMigrate test flaky

2 participants