Merged
Conversation
Signed-off-by: Carlos Martín <carlos.martin.sanchez@gmail.com>
Signed-off-by: Carlos Martín <carlos.martin.sanchez@gmail.com>
Signed-off-by: Carlos Martín <carlos.martin.sanchez@gmail.com>
smacker
approved these changes
Mar 22, 2019
se7entyse7en
approved these changes
Mar 22, 2019
Contributor
se7entyse7en
left a comment
There was a problem hiding this comment.
👍 Thanks also for the tests!
I'm gonna open an issue for the Python part just to not forget about it, I'm gonna check it next to what I'm doing.
Contributor
|
I was thinking that actually the Wrapped context AFAIR is actually not available at all in the interceptors as the api exposes a different data structure. If we want to enable to user to handle log fields inside the interceptors also for the Python SDK I think that we need to open an issue and investigate how we can approach it. |
Contributor
|
I had a look and it is always possible to handle log fields inside client interceptors as it is handled differently. But it's not documented how to do it, it's just used for client logger interceptors. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #84.
While migrating lookout I noticed that we can't use
pb.AddFieldsinside a client interceptor. This is becausepb.DialContextWithInterceptorswas executingCtxlog*ClientInterceptorbefore the user provided ones.With the change in this PR the interceptors are called in this order:
Instead of the previous one:
@se7entyse7en can you please check if we can have a similar problem in the python API?