add ToStruct method to go sdk#33
Merged
smacker merged 1 commit intosrc-d:masterfrom Nov 23, 2018
smacker:go_sdk_to_struct
Merged
add ToStruct method to go sdk#33smacker merged 1 commit intosrc-d:masterfrom smacker:go_sdk_to_struct
smacker merged 1 commit intosrc-d:masterfrom
smacker:go_sdk_to_struct
Conversation
Signed-off-by: Maxim Sukharev <max@smacker.ru>
carlosms
approved these changes
Nov 23, 2018
Contributor
carlosms
left a comment
There was a problem hiding this comment.
LGTM
Is there a reason for it to be ToPBStruct in lookout and ToStruct here?
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
move
ToStructmethods from lookout to sdk.It's easy to work with protobuf structs in other languages, for example python. But a lot of pain in go.
Analyzers need this method for unit testing.