allow file schema for repositories#27
Merged
smacker merged 2 commits intosrc-d:masterfrom Nov 14, 2018
smacker:allow_file_schema
Merged
allow file schema for repositories#27smacker merged 2 commits intosrc-d:masterfrom smacker:allow_file_schema
smacker merged 2 commits intosrc-d:masterfrom
smacker:allow_file_schema
Conversation
Signed-off-by: Maxim Sukharev <maxim@sourced.tech>
carlosms
reviewed
Nov 13, 2018
| if u.Scheme == "file" { | ||
| return &RepositoryInfo{ | ||
| CloneURL: input, | ||
| FullName: u.Path, |
Contributor
There was a problem hiding this comment.
What about adding also Name: filepath.Base(u.Path)?
Signed-off-by: Maxim Sukharev <maxim@sourced.tech>
Contributor
Author
|
ci is failing because can't download binary as usual |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
we need to support file schema too.
we use it in lookout-sdk binary.