Skip to content

Commit 188752b

Browse files
committed
move mention about python server.add_insecure_port in readme
Signed-off-by: Maxim Sukharev <max@smacker.ru>
1 parent 7113632 commit 188752b

1 file changed

Lines changed: 3 additions & 2 deletions

File tree

README.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,13 +27,14 @@ For the gRPC client and server please follow these requirements:
2727
- support [RFC 3986 URI scheme](https://github.com/grpc/grpc-go/issues/1911); lookout-sdk includes helpers for this:
2828
- go: using `pb.ToGoGrpcAddress` and `pb.Listen`.
2929
- python: using `lookout.sdk.grpc.to_grpc_address`.
30+
- use insecure connection:
31+
- currently lookout expects to use insecure gRPC connections, as provided by `pb.DialContext`
32+
- python: run server using `server.add_insecure_port(address)` ([example](https://github.com/src-d/lookout-sdk/blob/master/examples/language-analyzer.py#L63)).
3033

3134
## DataService
3235

3336
When DataService is being dialed, you should:
3437

35-
- disable secure connection:
36-
- python: using `server.add_insecure_port(address)` ([example](https://github.com/src-d/lookout-sdk/blob/master/examples/language-analyzer.py#L63)).
3738
- turn off [gRPC fail-fast](https://github.com/grpc/grpc/blob/master/doc/wait-for-ready.md) mode if your analyzer creates a connection to DataServer before it was actually started. This way the RPCs are queued until the chanel is ready:
3839
- go: using `grpc.FailFast(false)`
3940
([example](https://github.com/src-d/lookout-gometalint-analyzer/blob/7b4b37fb3109299516fbb43017934d131784f49f/cmd/gometalint-analyzer/main.go#L66)).

0 commit comments

Comments
 (0)