remove lookout as dependency use lookout-sdk instead#17
Merged
smacker merged 2 commits intosrc-d:masterfrom Nov 28, 2018
smacker:remove_dependency_on_lookout
Merged
remove lookout as dependency use lookout-sdk instead#17smacker merged 2 commits intosrc-d:masterfrom smacker:remove_dependency_on_lookout
smacker merged 2 commits intosrc-d:masterfrom
smacker:remove_dependency_on_lookout
Conversation
dpordomingo
approved these changes
Nov 26, 2018
dpordomingo
reviewed
Nov 26, 2018
| types "github.com/gogo/protobuf/types" | ||
| "github.com/src-d/lookout" | ||
| log "gopkg.in/src-d/go-log.v1" | ||
| "gopkg.in/src-d/lookout-sdk.v0/pb" |
There was a problem hiding this comment.
I think we should also add lookout-sdk into Gopkg.toml, shouldn't we?
[[constraint]]
name = "gopkg.in/src-d/lookout-sdk.v0"
Contributor
Author
There was a problem hiding this comment.
it's part of TODO. Replace lookout with lookout-sdk in dep. But we need new version of sdk first :)
Signed-off-by: Maxim Sukharev <max@smacker.ru>
Signed-off-by: Maxim Sukharev <max@smacker.ru>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Beside obvious downside of using lookout, people start copying code which makes sense as this is the first go analyzer mentioned in lookout readme.