skip draft pull requests#615
Merged
smacker merged 1 commit intosrc-d:masterfrom Apr 3, 2019
smacker:draft_prs_support
Merged
Conversation
carlosms
approved these changes
Apr 2, 2019
se7entyse7en
approved these changes
Apr 2, 2019
github doesn't run any checks on draft PRs emulate this behaviour by skipping prs as long as they are draft fix: #596 Signed-off-by: Maxim Sukharev <max@smacker.ru>
Contributor
Author
|
re-pushed with the test |
Contributor
|
LGTM 👍 |
carlosms
approved these changes
Apr 3, 2019
carlosms
reviewed
Apr 3, 2019
| if called { | ||
| cancel() | ||
| } | ||
| fmt.Fprint(w, `[{"id":1},{"id":2,"draft":true},{"id":3}]`) |
Contributor
There was a problem hiding this comment.
Wound't it be better to use lookout-test-fixtures here?
Contributor
Author
There was a problem hiding this comment.
- It's a unit test, usually, it's a bad idea to use huge fixtures in unit tests. Unit tests should test the smallest part of the logic possible and it should be easy to understand what they do.
- We don't have fixtures for PRs list in lookout-test-fixtures repository.
Contributor
There was a problem hiding this comment.
I don't entirely agree. In my opinion using fixture data does not automatically transform a unit test into an integration test. In this case the fixture is even vendored, so it's not so different from a hardcoded string.
But I don't want to block this PR for this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
github doesn't run any checks on draft PRs
emulate this behaviour by skipping prs as long as they are draft
fix: #596