Skip to content

Set defaults for GITHUB_USER and GITHUB_TOKEN#405

Merged
dpordomingo merged 1 commit intosrc-d:masterfrom
dpordomingo:gh-values-defaults
Dec 10, 2018
Merged

Set defaults for GITHUB_USER and GITHUB_TOKEN#405
dpordomingo merged 1 commit intosrc-d:masterfrom
dpordomingo:gh-values-defaults

Conversation

@dpordomingo
Copy link
Copy Markdown
Contributor

@dpordomingo dpordomingo commented Dec 10, 2018

fix #384

Use docker-compose defaults for:

GITHUB_USER
GITHUB_TOKEN

@dpordomingo
Set defaults for GITHUB_USER and GITHUB_TOKEN
bfca947 
Signed-off-by: David Pordomingo <David.Pordomingo.F@gmail.com>
@dpordomingo dpordomingo self-assigned this Dec 10, 2018
@dpordomingo dpordomingo added the enhancement New feature or request label Dec 10, 2018
@dpordomingo dpordomingo mentioned this pull request Dec 10, 2018
Closed
@dpordomingo dpordomingo added the empathy-sessions Issue filed as as part of empathy sessions label Dec 10, 2018
carlosms
carlosms approved these changes Dec 10, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@carlosms carlosms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@dpordomingo dpordomingo merged commit f87d80b into src-d:master Dec 10, 2018
@dpordomingo dpordomingo deleted the gh-values-defaults branch December 10, 2018 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@smacker smacker smacker approved these changes

@carlosms carlosms carlosms approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@dpordomingo dpordomingo

Labels

empathy-sessions Issue filed as as part of empathy sessions enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Warnings on docker-compose pull

3 participants

@dpordomingo @smacker @carlosms