fix: Use string instead of reflect.Type as log field#396
Merged
smacker merged 1 commit intosrc-d:masterfrom Dec 7, 2018
smacker:fix_event_type_log_field
Merged
fix: Use string instead of reflect.Type as log field#396smacker merged 1 commit intosrc-d:masterfrom smacker:fix_event_type_log_field
smacker merged 1 commit intosrc-d:masterfrom
smacker:fix_event_type_log_field
Conversation
With JSON formatter reflect.Type is formatted as "{}"
Example from staging logs:
{
"app":"lookoutd",
"event-id":"6052c4a4bda3c9807c9ec80c0955f85ee709a359",
"event-type":{},
"head":"refs/pull/395/head",
"level":"info",
"msg":"processing pull request",
"provider":"github",
"repo":"https://github.com/src-d/lookout.git",
"source":"server/server.go:116",
"time":"2018-12-07T10:57:47.489675762Z"
}
Signed-off-by: Maxim Sukharev <max@smacker.ru>
carlosms
approved these changes
Dec 7, 2018
dpordomingo
approved these changes
Dec 7, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With JSON formatter reflect.Type is formatted as "{}"
Example from staging logs:
Signed-off-by: Maxim Sukharev max@smacker.ru