Skip to content

Conversation

@meyskens
Copy link
Contributor

@meyskens meyskens commented Jul 12, 2019

This upgrades the Helm plugin to work with the latest Helm version.

Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
@meyskens meyskens requested a review from dpordomingo July 15, 2019 09:09
Copy link
Contributor

@dpordomingo dpordomingo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks in Staging

UPGRADE FAILED
Error: incompatible versions client[v2.14.1] server[v2.8.2]
Error: UPGRADE FAILED: incompatible versions client[v2.14.1] server[v2.8.2]
time="2019-07-16T11:03:17Z" level=fatal msg="Error running helm command: upgrade
    --install landing ./helm-charts/landing --set image.tag=commit-da21f71
    --values .helm-staging.yml --tiller-namespace kube-system --wait"

If I understood the roadmap at https://github.com/src-d/infrastructure/issues/982#issuecomment-510949827, we're still at stage 2, so waiting for https://github.com/src-d/infrastructure/pull/983 to be merged and released.

@driosalido
Copy link
Contributor

Yes, we are not ready yet to merge, just needed approval. It will work once we have updated the tiller.

@driosalido
Copy link
Contributor

@dpordomingo , helm updated in staging. Could you please check it again if it works in staging? Same thing for src-d/code-annotation#254

@dpordomingo
Copy link
Contributor

dpordomingo commented Jul 18, 2019

(... you can disregard this one; it worked.)

Copy link
Contributor

@dpordomingo dpordomingo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It worked in staging https://drone.srcd.host/src-d/landing/724
https://landing-staging.srcd.run/, so LGTM
Feel free to merge and release according to your plans. Many thanks!

@driosalido driosalido merged commit ff9a749 into master Jul 19, 2019
@driosalido driosalido deleted the helm-214 branch July 19, 2019 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants