This repository was archived by the owner on Jan 28, 2021. It is now read-only.
*: implement subquery expressions#835
Merged
ajnavarro merged 1 commit intosrc-d:masterfrom Oct 14, 2019
Merged
Conversation
agarciamontoro
approved these changes
Oct 8, 2019
Contributor
agarciamontoro
left a comment
There was a problem hiding this comment.
Great work. Reviewing such a big addition in go-mysql-server made me learn a lot! :)
There are some minor nitpicking comments below.
a887a9e to
e78ff1b
Compare
Contributor
Author
|
Done |
e78ff1b to
b533f9f
Compare
agarciamontoro
approved these changes
Oct 9, 2019
ajnavarro
suggested changes
Oct 9, 2019
Contributor
ajnavarro
left a comment
There was a problem hiding this comment.
LGTM. Shall we edit this too? https://github.com/src-d/go-mysql-server/blob/master/SUPPORTED.md#subqueries
b533f9f to
321f2a9
Compare
Contributor
Author
|
Changed supported.md |
ajnavarro
approved these changes
Oct 9, 2019
Contributor
|
@erizocosmico could you rebase to fix CI? thanks! |
Signed-off-by: Miguel Molina <miguel@erizocosmi.co>
Contributor
Author
|
Done |
321f2a9 to
258a735
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #59