This repository was archived by the owner on Jan 28, 2021. It is now read-only.
plan: return types in lowercase in SHOW CREATE TABLE#827
Merged
ajnavarro merged 1 commit intosrc-d:masterfrom Oct 1, 2019
Merged
plan: return types in lowercase in SHOW CREATE TABLE#827ajnavarro merged 1 commit intosrc-d:masterfrom
ajnavarro merged 1 commit intosrc-d:masterfrom
Conversation
Fixes #962 It solves a compatibility issue with SQLAlchemy, as it did not return the types the same way MySQL does. Signed-off-by: Miguel Molina <miguel@erizocosmi.co>
ajnavarro
approved these changes
Sep 30, 2019
agarciamontoro
approved these changes
Sep 30, 2019
Contributor
|
Seems like nodejs integration tests are failing. |
smacker
approved these changes
Sep 30, 2019
Contributor
smacker
left a comment
There was a problem hiding this comment.
nodejs fails because of something else. It can't download a dependency.
juanjux
approved these changes
Oct 1, 2019
Contributor
|
Ignoring node integration tests for now and merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes src-d/gitbase#962
It solves a compatibility issue with SQLAlchemy, as it did not return
the types the same way MySQL does.