Skip to content
This repository was archived by the owner on Jan 28, 2021. It is now read-only.

analyzer: do not erase sort node when pushing it down#818

Merged
ajnavarro merged 1 commit intosrc-d:masterfrom
erizocosmico:fix/orderby-missing-col
Oct 1, 2019
Merged

analyzer: do not erase sort node when pushing it down#818
ajnavarro merged 1 commit intosrc-d:masterfrom
erizocosmico:fix/orderby-missing-col

Conversation

@erizocosmico
Copy link
Contributor

@erizocosmico erizocosmico commented Sep 13, 2019

Fixes #813

It turns out there was a case in which a sort node could be removed

Signed-off-by: Miguel Molina <miguel@erizocosmi.co>
@erizocosmico erizocosmico requested a review from a team September 13, 2019 09:22
@ajnavarro ajnavarro requested a review from a team September 30, 2019 08:54
@ajnavarro ajnavarro requested a review from juanjux September 30, 2019 09:29
@ajnavarro ajnavarro merged commit d434557 into src-d:master Oct 1, 2019
@Hydrocharged Hydrocharged mentioned this pull request Oct 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ORDER BY does not fail on non-existent columns

3 participants