Merged
Conversation
jfontan
reviewed
Jul 16, 2019
discovery/gh-discovery.go
Outdated
|
|
||
| // GHDiscovery will retrieve the information for all the repositories for the | ||
| // given GHRepositoriesIterator. | ||
| type GHDiscovery struct { |
Contributor
There was a problem hiding this comment.
Why not GitHub? It's already in discovery package. Same for the file name discovery/github.go.
jfontan
reviewed
Jul 16, 2019
provider/gh-provider.go
Outdated
|
|
||
| // NewGHOrgProvider builds a new gitcollector.Provider | ||
| // based on a discovery.GHDiscovery. | ||
| func NewGHOrgProvider( |
Contributor
There was a problem hiding this comment.
Same comment as with discovery.GHDiscovery. This is already in provider package so it could be provider.NewGitHubOrg.
jfontan
approved these changes
Jul 16, 2019
Contributor
jfontan
left a comment
There was a problem hiding this comment.
Only the nit pick about duplicating the name of the package in structs and files. Other than that LGTM!
Signed-off-by: Manuel Carmona <manu.carmona90@gmail.com>
bd85997 to
62a8ad4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Manuel Carmona manu.carmona90@gmail.com