Define a persistentVolume for internal database #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rporres
suggested changes
Feb 13, 2018
| # tag must be received as a parameter | ||
| pullPolicy: IfNotPresent | ||
| deployment: | ||
| internalDatabasePath: /var/code-annotation |
There was a problem hiding this comment.
If there's no env variable that will inform that this may change beyond the default, I would not give the possibility of overriding it and I would hardcode it in the deployment yaml template
Contributor
Author
There was a problem hiding this comment.
I think this bfa612c is what you're looking for... isn't it?
rporres
approved these changes
Feb 13, 2018
Contributor
Author
|
You're right, thanks for spotting it @rporres |
smacker
approved these changes
Feb 13, 2018
bfa612c to
ce89db0
Compare
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR only prepares the volume where the sqlite should be
scped (the app will be prepared in a separated PR)As I was talking with @rporres we're not still supporting Postgresql in staging but sqlite.
After this PR is merged, it will be needed to push a sqlite bd into the volume as described by https://github.com/src-d/issues-infrastructure/issues/129