use go dep for dependency management #33
Conversation
bzz
left a comment
There was a problem hiding this comment.
LGTM.
One request, if possible, is there any chance we could merge #29 first and then, in here, also update CONTRIBUTING.md, pointing out that dep is used on a backend for dependency management, with a link to something like https://golang.github.io/dep/docs/daily-dep.html ?
Asking as this would help to assimilate the knowledge, necessary to adopt dep for other projects.
mcuadros
left a comment
There was a problem hiding this comment.
vendor folder should be upload, otherwise is anti-pattern in go
|
@mcuadros it's not true if we use dep: https://golang.github.io/dep/docs/FAQ.html#best-practices |
Signed-off-by: Maxim Sukharev <maxim@sourced.tech>
Signed-off-by: Maxim Sukharev <maxim@sourced.tech>
|
I don't think it's very right decision for this project because go here isn't the main part and in my opinion, it's better to follow the same patterns for all parts of the project. But vendor dir is added. |
|
vendor directory is added as Maximo requested. I need this PR to merge another one on top of is so, I'm merging (there are 2 approvals already includes maintainer) |
|
Why was this PR merged? With a pending request? |
|
the request is done. |
|
oh. and if you are talking about @dpordomingo review, we have an agreement to add everyone of the team in CR. But merge when there is approve of maintainer + 1 more. |
|
Who should confirm if the changes were addressed is the author of the request, since now that the vendor is there the rule |
|
godep is still needed for development. Please feel free to add any comments. They will be resolved in additional PRs. |
|
Also will be nice upload only the package that are you using running first |
|
Thanks for the suggestion. I created an issue: #39 |
Fixes: #13